Repository navigation
lib: remove obsolete Atomics.pause parameter - #65352
Open
Jemmy (JemmyIndex) wants to merge 1 commit into
Open
Jemmy (JemmyIndex) wants to merge 1 commit into
Jemmy (JemmyIndex) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change aligning Atomics.pause with the draft’s zero-argument signature.
No open issues 🎉
What changed in this PR
Updates TypeScript’s bundled Atomics.pause declaration to match the ECMAScript draft’s zero-argument signature, addressing #65339.
Changes:
- Removes the obsolete optional numeric parameter.
- Updates the existing conformance baselines to preserve
Atomics.pause()support and expect TS2554 forAtomics.pause(1).
| File | Description |
|---|---|
tsc/testdata/baselines/reference/conformance/esnextSharedMemory.types |
Updates expected types to the zero-argument signature. |
tsc/testdata/baselines/reference/conformance/esnextSharedMemory.errors.txt |
Adds the expected TS2554 diagnostic for an argument. |
tsc/internal/bundled/libs/lib.esnext.sharedmemory.d.ts |
Changes the declaration to pause(): void. |
Review effort: Balanced
Jake Bailey (jakebailey)
approved these changes
Nov 6, 2026
Jake Bailey (jakebailey)
enabled auto-merge
November 6, 2026 22:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65339.
The current ECMAScript draft defines
Atomics.pause()with no arguments, but the bundled declaration still accepts an optional number. Remove the obsolete parameter soAtomics.pause(1)reports TS2554 whileAtomics.pause()continues to compile. TC39's rationale explains why the parameter was removed.The existing
esnextSharedMemoryconformance case already exercises both calls. Update its type baseline and add the expected diagnostic baseline; no new test case is needed.Validation:
Atomics.pause()and reports TS2554 forAtomics.pause(1.5).validate --allcompleted: build, compiler/conformance, parser, fourslash, CLI, extension, native/WASM API, lint and formatting checks passed. Its overall exit status is unsuccessful becauseTestSubscribeSymlinkCreate/windowsandTestSubscribeSymlinkDelete/windowscannot create symlinks on this machine (A required privilege is not held by the client). Both were reproduced independently.hereby tidypassed without dependency changes.AI assistance: This patch and its validation were prepared with Codex.